Fix errors creating snapshot and stories files due to multi-bytes test names #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakker1218
changed the title
|
I would like to validate the fix by testing it against the results of the failed action. The fix I plan to apply is in the following commit: nakker1218@6334588. Hi @tevanoff, If possible, could you provide support with this? If it's difficult, could you point me to the right person to contact? |
|
Hello, thank you for contributing! I've pulled your changes into #219 to run the workflow and we're looking good so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #195
What Changed
In test cases containing multi-byte characters, "name too long" errors were occurring even when the file name was under 255 characters.
This issue arises because, on most platforms, the file name size is determined by the number of bytes rather than the number of characters.
To address this, the logic for truncating snapshot IDs and story file names has been updated to use byte size instead of character count.
This change ensures that test cases with multi-byte characters will no longer trigger "name too long" errors as described above.
Related PR: #175
How to test